GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fixes crash by making sure arrays are the correct dimensions
Issue #2611: MiniBatchKmeans crashes
Coverage remained the same when pulling 20dda7d on czxcjx:minibatchkmeans into 699079e on scikit-learn:master.
LGTM. I actually saw the same problem yesterday and coded up a fix ;) that is basically identical to yours. Could you please provide a regression test?
actually my branch has a regression test I think, so I might just use that if thats ok with you. see #2638.
@amueller I think this has been fixed, right?