Skip to content

ENH make fit_transform and fit_predict composite methods (SLEP6)#26506

Merged
glemaitre merged 15 commits into
scikit-learn:mainfrom
adrinjalali:slep6/composit_method
Jun 21, 2023
Merged

ENH make fit_transform and fit_predict composite methods (SLEP6)#26506
glemaitre merged 15 commits into
scikit-learn:mainfrom
adrinjalali:slep6/composit_method

Conversation

@adrinjalali

Copy link
Copy Markdown
Member

Moving #24585 here to be merged to main.

This is specifically required for the work on Pipeline.

@adrinjalali

Copy link
Copy Markdown
Member Author

@glemaitre you already signed off on the original PR, so maybe you could do here too? 😁

@glemaitre

Copy link
Copy Markdown
Member

Promise I will give a review by tomorrow

@glemaitre glemaitre self-requested a review June 14, 2023 20:10
Comment thread sklearn/utils/_metadata_requests.py Outdated
Comment thread sklearn/tests/test_metadata_routing.py Outdated
Comment thread sklearn/tests/test_metadata_routing.py Outdated
Comment thread doc/whats_new/v1.3.rst Outdated

@thomasjpfan thomasjpfan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks

Comment thread doc/whats_new/v1.4.rst Outdated
Comment thread sklearn/tests/test_metadata_routing.py
Comment thread sklearn/tests/test_metadata_routing.py Outdated
@github-actions

Copy link
Copy Markdown

Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

@glemaitre glemaitre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promise I will give a review by tomorrow

Apparently I have no tomorrow ;)

@glemaitre glemaitre enabled auto-merge (squash) June 21, 2023 12:49
@glemaitre glemaitre merged commit 4163b32 into scikit-learn:main Jun 21, 2023
@adrinjalali adrinjalali deleted the slep6/composit_method branch June 21, 2023 14:08
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants