Repository navigation
ENH warn if {transform, predict} consume metadata but no custom fit_{transform, predict} is defined - #26831
Merged
OmarManzoor merged 4 commits intoJul 14, 2023
Conversation
…transform, predict} is defined
OmarManzoor
reviewed
Jul 14, 2023
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Member
Author
|
@OmarManzoor wanna push the green button 😁 ? |
Contributor
Sure 🙂 |
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
…transform, predict} is defined (scikit-learn#26831) Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…transform, predict} is defined (scikit-learn#26831) Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
StefanieSenger
added
the
Metadata Routing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #26789 we encountered a case where
transformwould consume a metadata, but pipeline would callfit_transformwhich only routes metadata tofit. This PR makes it so that in those cases a warning is raised.cc @glemaitre