TST Extend tests for scipy.sparse.*array in sklearn/feature_selection/tests/test_feature_select.py

[Tialo]

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

[github-actions]

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: fbd2716. Link to the linter CI: here}

[glemaitre]

LGTM. Thanks @Tialo

[glemaitre]

Actually, the implementation of r_regression is not compatible. I have to check the reason.

[glemaitre]

You need to edit the file sklearn/feature_selection/_univariate_selection.py in l.326 and replace the code from:

        if issparse(X):
            X_means = X.mean(axis=0).getA1()
        else:
            X_means = X.mean(axis=0)

to

        if isspmatrix(X):
            X_means = X.mean(axis=0).getA1()
        else:
            X_means = X.mean(axis=0)

You should import isspmatrix from scipy.sparse

[Tialo]

Thanks for fix!

[glemaitre]

I fixed the linting problem by removing the useless import. I also added an entry in the changelog at the same time since we are modifying some public facing code.

LGTM otherwise. @OmarManzoor feel free to have a look at this one.

[glemaitre]

Feel free to update your name (only the first mention since the second one link to your GitHub handle). This is also fine keeping it as-is.

[OmarManzoor]

Thanks @Tialo for the PR.

[OmarManzoor]

I made the minor changes. LGTM.

[Tialo]

Thanks! I changed my name, ready to merge

[glemaitre]

Oh apparently there is a new deprecation warning. I made the changes. We should be good to go.
I enable the auto-merge if the CIs are passing.