Repository navigation
TST Extend tests for scipy.sparse/*array in sklearn/impute/tests/test_common - #27277
Merged
Merged
Conversation
OmarManzoor
reviewed
Sep 6, 2023
OmarManzoor
left a comment
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @Charlie-XIAO. Some minor comments.
OmarManzoor
approved these changes
Sep 7, 2023
OmarManzoor
left a comment
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @Charlie-XIAO
glemaitre
self-requested a review
September 11, 2023 17:41
glemaitre
reviewed
Sep 11, 2023
Contributor
Author
|
@glemaitre I've specified the format in |
Member
|
Nice. Indeed, we need a changelog entry as well. |
glemaitre
self-requested a review
September 15, 2023 19:41
glemaitre
approved these changes
Sep 15, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…est_common` (scikit-learn#27277) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #27090.
I made the
.tocsr()change becausescipy.sparse.hstackwould cause the output to becomecoo_matrixwhen input is sparse array, andcoo_matrixdoes not support slicing.