FEA Add metadata routing to GraphicalLassoCV#27566
FEA Add metadata routing to GraphicalLassoCV#27566adrinjalali merged 10 commits intoscikit-learn:mainfrom
Conversation
|
|
||
|
|
||
| @pytest.mark.usefixtures("enable_slep006") | ||
| def test_graphical_lasso_cv_scores_with_routing(global_random_seed): |
There was a problem hiding this comment.
why do we need this on top of test_metadata_is_routed_correctly_to_splitter?
There was a problem hiding this comment.
This is a test which checks when we route the groups parameter the graphical lasso cv still operates correctly and gives the desired results.
There was a problem hiding this comment.
Yes, but we don't have the equivalent test for all the other *CV classes. I'm thinking what could go wrong if we don't have this test.
There was a problem hiding this comment.
I still don't see what this test brings on top of the common test we have
There was a problem hiding this comment.
This checks for the actual results and values to ensure the output is as desired after routing parameters.
There was a problem hiding this comment.
I think even if this test might be additional or extra maybe it would still be nice to have it since it compares the values? Let me know what you think @adrinjalali @glemaitre . Otherwise we can remove it to finalize this PR.
|
@adrinjalali Could you kindly have a look at this one too? |
| ) | ||
|
|
||
|
|
||
| # TODO(1.5): remove in 1.5 |
There was a problem hiding this comment.
I don't think this is removed in main yet. I think you see this change only because of the rearrangement otherwise this is not part of this PR.
|
|
||
|
|
||
| @pytest.mark.usefixtures("enable_slep006") | ||
| def test_graphical_lasso_cv_scores_with_routing(global_random_seed): |
There was a problem hiding this comment.
I still don't see what this test brings on top of the common test we have
3 participants
Reference Issues/PRs
Towards #22893
What does this implement/fix? Explain your changes.
Any other comments?
CC: @adrinjalali @glemaitre