-
-
Notifications
You must be signed in to change notification settings - Fork 26k
FIX update create_memmap_backed_data to work on any estimator object via joblib 1.2.0 and later #27614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
glemaitre
merged 6 commits into
scikit-learn:main
from
ogrisel:fix-check_estimators_pickle
Oct 22, 2023
Merged
FIX update create_memmap_backed_data to work on any estimator object via joblib 1.2.0 and later #27614
glemaitre
merged 6 commits into
scikit-learn:main
from
ogrisel:fix-check_estimators_pickle
Oct 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! yes I can confirm that this fixes the problem for me |
glemaitre
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A bit to quick at approving. Apparently it does not work in Windows:
but it might be more linked to the following:
|
glemaitre
reviewed
Oct 18, 2023
ogrisel
commented
Oct 18, 2023
@glemaitre this should be all-green now. Feel free to re-review. |
LGTM. Thanks @ogrisel |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2023
…via joblib 1.2.0 and later (scikit-learn#27614)
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…via joblib 1.2.0 and later (scikit-learn#27614)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27613.
Note that on recent versions of joblib (after version 1.2.0)
joblib.load(filepath, mmap_model="r")
automatically allocates aligned memmap arrays (thanks to @lesteve's work), so there is no need for special casing anymore.@jeromedockes can you please check that this fixes the problem for you? If so I will complete the PR to clean-up old code, set
JOBLIB_MIN_VERSION
to1.2.0
instead of1.1.1
and document it all in whats new.EDIT: I simplified the code to always rely on joblib to allocate aligned memory mapped arrays. This made it possible to delete the broken fallback helper functions that did not work as intended in the specific runtime environment of Jerome.