Skip to content

ENH add predict_log_proba to ClassifierChain#27720

Merged
thomasjpfan merged 2 commits into
scikit-learn:mainfrom
glemaitre:classifier_chain_predict_log_proba
Dec 6, 2023
Merged

ENH add predict_log_proba to ClassifierChain#27720
thomasjpfan merged 2 commits into
scikit-learn:mainfrom
glemaitre:classifier_chain_predict_log_proba

Conversation

@glemaitre

Copy link
Copy Markdown
Member

Encounter in #27700 and #27719

This PR implements predict_log_proba in ClassifierChain whenever the predict_proba method is available.

@github-actions

github-actions Bot commented Nov 3, 2023

Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: c2eb71c. Link to the linter CI: here

@OmarManzoor OmarManzoor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @glemaitre

@OmarManzoor OmarManzoor added the Waiting for Second Reviewer First reviewer is done, need a second one! label Dec 4, 2023

@thomasjpfan thomasjpfan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 36f6734 into scikit-learn:main Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for Second Reviewer First reviewer is done, need a second one!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants