FIX ensure consistency or column and feature names in FunctionTransformer #27801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
commented
Nov 17, 2023
| @@ -330,7 +330,7 @@ def test_function_transformer_get_feature_names_out( | |||
| transformer = FunctionTransformer( | |||
| feature_names_out=feature_names_out, validate=validate | |||
| ) | |||
| transformer.fit_transform(X) | |||
| transformer.fit(X) | |||
There was a problem hiding this comment.
Calling transform allows us to find the issue with the number of columns and the function used here. Therefore, we can call fit to avoid this check.
|
So here, we only raise a better error message. There is no magic but we provide an explanation what to do. I am not a big fan of the magical solution and I am not sure that we will be able to somehow return the expected type (NumPy vs. Pandas) since it will depend of what |
thomasjpfan
added
the
Waiting for Second Reviewer
|
Needs sync with main before merging. |
|
Thanks @lesteve for syncing the PR. Merging with the 2 above approvals. |
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27695
Raise an explicit error when the column names of the container given by
transformis not consistent with the output ofget_feature_names_outinFunctionTransformer.In #27695, the error raised is not easy to understand when the
FunctionTransformeris embedded within aPipeline.Here, we also give some solution how to resolve the problem.
I see that we have test failing in our test suite. I need to check if they are legitimate. I see that some come from the fact that
feature_names_outreturn less names than the number of columns inX_trans.