Repository navigation
DEP deprecate loss_function_ attribute in SGDClassifier and SGDOneClassSVM - #27979
Merged
jeremiedbb merged 4 commits intoDec 19, 2023
Merged
Conversation
Member
Author
|
@glemaitre @lesteve @jeremiedbb @jjerphan As we won't rush 1.4. anyway, could we get this deprecation in? 🙏 |
jeremiedbb
approved these changes
Dec 19, 2023
jeremiedbb
left a comment
jeremiedbb
left a comment
Member
There was a problem hiding this comment.
LGTM. I just pushed a few changes for consistency in version numbers
jeremiedbb
enabled auto-merge (squash)
December 19, 2023 13:49
Member
Author
|
@jjerphan @jeremiedbb Thanks for the quick review! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
This was referenced May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Helps with #15123 for SGD.
What does this implement/fix? Explain your changes.
Deprecate the attribute
loss_function_that accesses a Cython extension class inSGDClassifierandSGDOneClassSVM.Any other comments?
Let's try to include it in 1.4.