ENH verbose >= 2 for per iteration info in HGBT#28179
Merged
adam2392 merged 7 commits intoscikit-learn:mainfrom Jul 10, 2024
Merged
ENH verbose >= 2 for per iteration info in HGBT#28179adam2392 merged 7 commits intoscikit-learn:mainfrom
adam2392 merged 7 commits intoscikit-learn:mainfrom
Conversation
OmarManzoor
reviewed
Jun 28, 2024
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
Thanks for the PR @lorentzenchr . Shouldn't this require a change log entry considering the change in the behaviour of self.verbose?
OmarManzoor
approved these changes
Jul 1, 2024
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @lorentzenchr
OmarManzoor
added
the
Waiting for Second Reviewer
adam2392
approved these changes
Jul 10, 2024
Member
There was a problem hiding this comment.
LGTM otw! Thanks for the review @lorentzenchr.
There is a merge conflict as well to resolve
Member
Author
|
@OmarManzoor @adam2392 Thanks for your reviews. Usually, within the scikit-learn project, one of the reviewers merges. |
Member
|
Okay! I will turn on auto merge for the first time then. Exciting 😱 |
Member
Author
|
@adam2392 Congratulation to your first merge🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
This PR gives finer control over verbosity in
HistGradientBoostingClassifierandHistGradientBoostingRegressor, i.e. the per iteration info is only emitted forverbose >= 2.Any other comments?