ENH Add metadata routing for IterativeImputer - #28187
Merged
Merged
Conversation
adrinjalali
self-requested a review
January 22, 2024 12:40
adrinjalali
reviewed
Jan 22, 2024
adrinjalali
left a comment
adrinjalali
left a comment
Member
There was a problem hiding this comment.
Otherwise I think this looks pretty good.
adrinjalali
reviewed
Jan 26, 2024
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
21 of 28 tasks
Member
|
@glemaitre @OmarManzoor this is waiting for a second review. |
OmarManzoor
approved these changes
Feb 13, 2024
OmarManzoor
left a comment
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @StefanieSenger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #22893
What does this implement/fix? Explain your changes.
This PR adds metadata routing to
IterativeImputer.(I also corrected an error in the documentation for
SelectFromModelthat I've found along the way.)