Repository navigation
FIX handle dataframe in ARDRegression when predict requests std. dev. - #28377
Merged
Merged
Conversation
Contributor
Author
|
I checked the failing CI logs and it seems that some CI does not have pandas installed. Is there some other check that should be done. This is a very pandas/numpy specific issue so I figure it should be imported and used. |
eddiebergman
force-pushed
the
fix-28310
branch
from
February 7, 2024 10:55
d6059dd to
ed5a246
Compare
glemaitre
reviewed
Feb 8, 2024
glemaitre
left a comment
glemaitre
left a comment
Member
There was a problem hiding this comment.
You will need to add an entry in the changelog doc/whats_new/v1.4.rst (under 1.4.1) to acknowledge the fix.
glemaitre
changed the title
glemaitre
changed the title
eddiebergman
force-pushed
the
fix-28310
branch
from
February 8, 2024 12:06
8137d77 to
326ad90
Compare
glemaitre
reviewed
Feb 8, 2024
glemaitre
approved these changes
Feb 8, 2024
glemaitre
left a comment
glemaitre
left a comment
Member
There was a problem hiding this comment.
Otherwise LGTM. Thanks @eddiebergman
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
eddiebergman
force-pushed
the
fix-28310
branch
from
February 9, 2024 08:36
e3561b7 to
f53ae89
Compare
jeremiedbb
approved these changes
Feb 9, 2024
jeremiedbb
left a comment
jeremiedbb
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks @eddiebergman
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
…scikit-learn#28377) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
LeoGrin
pushed a commit
to LeoGrin/scikit-learn
that referenced
this pull request
Feb 12, 2024
…scikit-learn#28377) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 13, 2024
…scikit-learn#28377) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Feb 13, 2024
…#28377) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
ARDRegressorvariance prediction fails onX: pd.DataFrame#28310What does this implement/fix? Explain your changes.
Only change was just to use
_safe_indexing.Any other comments?
BayesianRidgewhich seems to be tightly related toArdRegressionin testing. The problem doesn't exist there as it doesn't use indexing.