FIX HDBSCAN allows all pairwise metrics when algorithm="brute"/"auto"#28664
Merged
jeremiedbb merged 10 commits intoscikit-learn:mainfrom Apr 17, 2024
Merged
FIX HDBSCAN allows all pairwise metrics when algorithm="brute"/"auto"#28664jeremiedbb merged 10 commits intoscikit-learn:mainfrom
jeremiedbb merged 10 commits intoscikit-learn:mainfrom
Conversation
yuanx749
reviewed
Mar 21, 2024
Contributor
yuanx749
left a comment
yuanx749
left a comment
There was a problem hiding this comment.
Hi @myenugula , I think we can also include other valid pairwise metrics.
jeremiedbb
reviewed
Apr 3, 2024
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
The fix looks good. Just a few nitpicks
jeremiedbb
changed the title
Contributor
Author
|
@jeremiedbb thank you for the review. I updated the PR accordingly |
jeremiedbb
approved these changes
Apr 17, 2024
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
I moved the changelog entry back into v1.5.rst because in the end we decided that 1.4.2 would only be about numpy 2 support. Sorry for the misleading request.
LGTM. Thanks @myenugula
|
Which sklearn version should I install to have this update? The dev one? |
Member
|
It will be available in the upcoming 1.5.0 ( very soon :) ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #28631
What does this implement/fix? Explain your changes.
It enables
HDBSCANto use "cosine" metric with "brute" or "auto" algorithms, enhancing clustering flexibility.