Deprecate cv_values_ in favour of cv_results_ in RidgeCV estimators#28915
Merged
Conversation
lucyleeow
changed the title
cv_values_ in favour of cv_results_cv_values_ in favour of cv_results_
lucyleeow
changed the title
cv_values_ in favour of cv_results_cv_values_ in favour of cv_results_ in RidgeCV estimators
adrinjalali
reviewed
Apr 30, 2024
adrinjalali
left a comment
adrinjalali
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR @lucyleeow . Also need to trigger a doc build to make sure we don't have this in our docs.
adrinjalali
approved these changes
May 2, 2024
adrinjalali
left a comment
adrinjalali
left a comment
Member
There was a problem hiding this comment.
Otherwise LGTM.
cc @jeremiedbb maybe?
jeremiedbb
approved these changes
May 2, 2024
jeremiedbb
left a comment
jeremiedbb
left a comment
Member
There was a problem hiding this comment.
LGTM. There's just a warning message mismatch. And +1 to mark None as Hidden (we won't start a deprecation cycle in 1.7 to remove None)
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
closes #7206
What does this implement/fix? Explain your changes.
Deprecate
cv_values_andstore_cv_valuesinRidgeCVandRidgeClassifierCVAny other comments?