FEA SLEP006: Metadata routing for learning_curve#28975
Merged
OmarManzoor merged 12 commits intoscikit-learn:mainfrom May 17, 2024
Merged
FEA SLEP006: Metadata routing for learning_curve#28975OmarManzoor merged 12 commits intoscikit-learn:mainfrom
learning_curve#28975OmarManzoor merged 12 commits intoscikit-learn:mainfrom
Conversation
adrinjalali
reviewed
May 14, 2024
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
only nits, and merge conflicts, otherwise nice one!
| sample_weight="fit_sample_weight", metadata="fit_metadata" | ||
| ) | ||
|
|
||
| if func is learning_curve: |
Member
There was a problem hiding this comment.
I would move this to a separate test instead of adding to this test.
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
StefanieSenger
commented
May 15, 2024
Member
Author
StefanieSenger
left a comment
StefanieSenger
left a comment
There was a problem hiding this comment.
@adrinjalali Thanks for your review. I've made that little change.
adrinjalali
approved these changes
May 15, 2024
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
@OmarManzoor @glemaitre could you have a look?
OmarManzoor
approved these changes
May 15, 2024
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @StefanieSenger
glemaitre
changed the title
learning_curvelearning_curve
28 tasks
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds metadata routing to
learning_curveby principally following the same pattern as incross_validate.Reference Issues/PRs
Towards #22893