ENH Add Array API compatibility to cosine_similarity#29014
ENH Add Array API compatibility to cosine_similarity#29014OmarManzoor merged 10 commits intoscikit-learn:mainfrom
cosine_similarity#29014Conversation
|
Thank you @ogrisel for the quick reply!
Yes, I tested on CUDA in Google Colab and on my Mac (using |
ogrisel
left a comment
There was a problem hiding this comment.
LGTM once the proposed argument renaming discussed above is implemented.
|
Thank you very much!:) |
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @EdAbati
|
@EdAbati Just for some guidance, how did you run this code in google colab so that we can test with gpus? |
|
Thanks again @OmarManzoor :) I just published the Google Colab notebook in a gist: https://gist.github.com/EdAbati/ff3bdc06bafeb92452b3740686cc8d7c |
Thank you for sharing! |

Reference Issues/PRs
Towards #26024
What does this implement/fix? Explain your changes.
It makes the
cosine_similarityimplementation compatible and tested with the Array API.Please let me know how I can improve it :)
cc @ogrisel @betatim