Skip to content

FEA Add metadata routing for TransformedTargetRegressor#29136

Merged
glemaitre merged 5 commits intoscikit-learn:mainfrom
OmarManzoor:target_regressor_routing
Jun 10, 2024
Merged

FEA Add metadata routing for TransformedTargetRegressor#29136
glemaitre merged 5 commits intoscikit-learn:mainfrom
OmarManzoor:target_regressor_routing

Conversation

@OmarManzoor
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Towards #22893

What does this implement/fix? Explain your changes.

  • Adds metadata routing to TransformedTargetRegressor

Any other comments?

CC: @adrinjalali

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 30, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e3b42a7. Link to the linter CI: here

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

Comment thread sklearn/compose/_target.py Outdated
Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @glemaitre

@glemaitre glemaitre self-requested a review June 6, 2024 08:22
y_trans = y_trans.squeeze(axis=1)

if self.regressor is None:
from ..linear_model import LinearRegression
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I would have think that we have a circular import but apparently this is not the case anymore.

@glemaitre glemaitre merged commit 8a5d8c3 into scikit-learn:main Jun 10, 2024
@OmarManzoor OmarManzoor deleted the target_regressor_routing branch June 20, 2024 08:23
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants