Skip to content

Conversation

@Tialo
Copy link
Contributor

@Tialo Tialo commented May 30, 2024

Towards #26024

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link

github-actions bot commented May 30, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a2d5a34. Link to the linter CI: here

Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo.

I verified that the tests pass with cuda and mps devices.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's see if the tests pass on CUDA GPUs with the following manually triggered CI run on our new CUDA CI infrastructure:

https://github.com/scikit-learn/scikit-learn/actions/runs/9399022364

@ogrisel
Copy link
Member

ogrisel commented Jun 6, 2024

For information, I tested locally with on Apple M1 to check the device="mps" case and the test passes:

sklearn/metrics/tests/test_common.py::test_array_api_compliance[mean_squared_error-check_array_api_regression_metric-torch-mps-float32] PASSED

@ogrisel
Copy link
Member

ogrisel commented Jun 6, 2024

I indeed forgot to merge main before triggering the CUDA GPU CI. Let me try again with the new state of the PR:

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM CUDA tests are green, thanks for the PR.

@ogrisel ogrisel enabled auto-merge (squash) June 6, 2024 12:20
@ogrisel ogrisel merged commit 08de29d into scikit-learn:main Jun 6, 2024
@Tialo Tialo deleted the array-api/mean_squared_error branch June 6, 2024 13:04
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants