ENH Add Array API compatibility for additive_chi2_kernel#29144
Merged
betatim merged 8 commits intoscikit-learn:mainfrom Jun 13, 2024
Merged
ENH Add Array API compatibility for additive_chi2_kernel#29144betatim merged 8 commits intoscikit-learn:mainfrom
additive_chi2_kernel#29144betatim merged 8 commits intoscikit-learn:mainfrom
Conversation
ogrisel
approved these changes
Jun 7, 2024
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM. Could you please just update the _array_api.rst documentation file to reference this function?
Member
|
And there are a bunch of conflicts to resolve when merging |
Member
|
Also please check that the CUDA tests pass with https://gist.github.com/EdAbati/ff3bdc06bafeb92452b3740686cc8d7c. |
Contributor
Author
|
CUDA tests passed |
Member
|
Ping @betatim @OmarManzoor. |
Member
|
I resolved the merge conflict and started the CUDA CI https://github.com/scikit-learn/scikit-learn/actions/runs/9501959732 edit: CI failed because I made a mistake when resolving the conflict. |
betatim
approved these changes
Jun 13, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #26024
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?
Due to
_chi2_kernel_fastwritten in cython it can't be used with array-api containers. So I implemented all calculations using array broadcasting. It is not faster than cython function, so I use_chi2_kernel_fastwhenadditive_chi2_kernelgets a numpy array.