Skip to content

add array API support for d2_tweedie_score#29207

Merged
OmarManzoor merged 4 commits into
scikit-learn:mainfrom
EmilyXinyi:array_API_d2_tweedie_score
Jun 7, 2024
Merged

add array API support for d2_tweedie_score#29207
OmarManzoor merged 4 commits into
scikit-learn:mainfrom
EmilyXinyi:array_API_d2_tweedie_score

Conversation

@EmilyXinyi

Copy link
Copy Markdown
Contributor

Reference Issues/PRs

towards #26024

What does this implement/fix? Explain your changes.

add array API support for d2_tweedie_score

Any other comments?

I still need to update the documentation.

@github-actions

github-actions Bot commented Jun 6, 2024

Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: dd3704a. Link to the linter CI: here

@ogrisel ogrisel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Apart from the formatting issue reported by the automated linter, this looks good to me.

Let me start a CUDA GPU CI run here:

If this is green and once the linting problem is fixed, +1 for merge on my end.

EDIT: CUDA CI is green.

@ogrisel ogrisel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @EmilyXinyi and welcome to the scikit-learn project!

@ogrisel ogrisel added the Waiting for Second Reviewer First reviewer is done, need a second one! label Jun 7, 2024
@ogrisel

ogrisel commented Jun 7, 2024

Copy link
Copy Markdown
Member

/cc @OmarManzoor

@OmarManzoor OmarManzoor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @EmilyXinyi

@OmarManzoor OmarManzoor merged commit e4362e5 into scikit-learn:main Jun 7, 2024
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
@EmilyXinyi EmilyXinyi deleted the array_API_d2_tweedie_score branch August 12, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Array API module:metrics Waiting for Second Reviewer First reviewer is done, need a second one!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants