ENH Add array_api compatibility to max_error#29212
ENH Add array_api compatibility to max_error#29212betatim merged 3 commits intoscikit-learn:mainfrom
max_error#29212Conversation
|
Had to change the type of Was there a reason why that was |
|
|
|
Thanks again for you Array API PRs @EdAbati. Since you already had quite a bit of experience on those I was wondering if you wouldn't be interested in contributing on PRs that are a bit less well defined but potentially more impactful from a performance point of view? For instance I think we could improve the array API support for the |
|
Hi @ogrisel , sounds good! I was also looking at |
|
I triggered the CUDA CI for this PR https://github.com/scikit-learn/scikit-learn/actions/runs/9500016241 (Mostly for my own sake to use the CI a bit) |
Reference Issues/PRs
Towards #26024
What does this implement/fix? Explain your changes.
It makes the
max_errorimplementation compatible and tested with the Array API.