FEA Add metadata routing for SequentialFeatureSelector#29260
Merged
Conversation
adam2392
reviewed
Jun 18, 2024
Member
adam2392
left a comment
adam2392
left a comment
There was a problem hiding this comment.
I left a few comments. Let me know if I misunderstood something tho.
| unsupervised learning. | ||
|
|
||
| **params : dict, default=None | ||
| Parameters to be passed to the cross_val_score function. |
Member
There was a problem hiding this comment.
Suggested change
| Parameters to be passed to the cross_val_score function. | |
| Parameters to be passed to the scoring function evaluated through cross validation | |
| via the `cross_val_score` function. |
Contributor
Author
There was a problem hiding this comment.
Within the cross_val_score function I think we route to more than just the scoring function. We also route to cv and estimator fit methods.
adam2392
reviewed
Jun 18, 2024
Co-authored-by: Adam Li <adam2392@gmail.com>
Member
|
I'll put this one on my todo list |
28 tasks
adrinjalali
reviewed
Jul 24, 2024
glemaitre
reviewed
Jul 24, 2024
adrinjalali
approved these changes
Jul 31, 2024
MarcBresson
pushed a commit
to MarcBresson/scikit-learn
that referenced
this pull request
Sep 2, 2024
…29260) Co-authored-by: Adam Li <adam2392@gmail.com> Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards: #22893
What does this implement/fix? Explain your changes.
Any other comments?
CC: @adrinjalali @glemaitre