array API support for cosine_distances #29265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Jun 14, 2024
ogrisel
reviewed
Jun 14, 2024
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
Here is some feedback. Please also test that this works on cuda devices with PyTorch and CuPy using:
https://gist.github.com/EdAbati/ff3bdc06bafeb92452b3740686cc8d7c
EdAbati
reviewed
Jun 17, 2024
Contributor
Author
Member
|
Merging main to hopefully get a green CI on this PR. |
ogrisel
reviewed
Jun 20, 2024
OmarManzoor
reviewed
Jun 25, 2024
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
Thanks for the PR @EmilyXinyi. A few comments otherwise looks good.
OmarManzoor
reviewed
Jul 8, 2024
EmilyXinyi
force-pushed
the
array_API_cosine_distance
branch
from
da921c4 to
12d5569
Compare
ogrisel
added
Waiting for Reviewer
Waiting for Second Reviewer
OmarManzoor
reviewed
Jul 12, 2024
OmarManzoor
removed
Waiting for Second Reviewer
OmarManzoor
approved these changes
Jul 12, 2024
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @EmilyXinyi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #26024
What does this implement/fix? Explain your changes.
array API support for
cosine_distancesAny other comments?
.clipis supported in the 2023.12 version but not the one that we are currently using, so I created a function insklearn.utils._array_apifor now.fill_diagonalis not supported and I don't see it being in the plan of being supported in the array-api repo, so I created an alternative._fill_diagonalinsklearn.metrics.pairwisePlease let me know if there are any changes I should make, thanks!