ENH Array API for chi2_kernel#29267
Merged
ogrisel merged 3 commits intoscikit-learn:mainfrom Jun 20, 2024
Merged
Conversation
Co-authored-by: Edoardo Abati <29585319+EdAbati@users.noreply.github.com>
EdAbati
approved these changes
Jun 16, 2024
Contributor
EdAbati
left a comment
EdAbati
left a comment
There was a problem hiding this comment.
Not sure if it counts, but LGTM :)
Contributor
|
Not sure if it counter either, but also LGTM :) |
EmilyXinyi
approved these changes
Jun 18, 2024
ogrisel
approved these changes
Jun 20, 2024
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
LGTM as well. Thanks all for the PR, reviews and making sure that the tests pass on CUDA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #26024
What does this implement/fix? Explain your changes.
Any other comments?