FEA SLEP006: Metadata routing for validation_curve#29329
Conversation
adam2392
left a comment
adam2392
left a comment
There was a problem hiding this comment.
Thanks for the PR @StefanieSenger! Left a few comments.
| Parameters directly passed to the `fit` method of the estimator. | ||
|
|
||
| - If `enable_metadata_routing=True`: | ||
| Parameters safely routed to the `fit` method of the estimator. | ||
| See :ref:`Metadata Routing User Guide <metadata_routing>` for more | ||
| details. |
There was a problem hiding this comment.
Same comment here. Since it's passed to more than the estimator fit. There's the scorer and CV
There was a problem hiding this comment.
Thank you @adam2392, that comment also made it more clear for myself.
Co-authored-by: Adam Li <adam2392@gmail.com>
StefanieSenger
left a comment
StefanieSenger
left a comment
There was a problem hiding this comment.
I've submitted your suggestions, @adam2392, thanks for your review.
| Parameters directly passed to the `fit` method of the estimator. | ||
|
|
||
| - If `enable_metadata_routing=True`: | ||
| Parameters safely routed to the `fit` method of the estimator. | ||
| See :ref:`Metadata Routing User Guide <metadata_routing>` for more | ||
| details. |
There was a problem hiding this comment.
Thank you @adam2392, that comment also made it more clear for myself.
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
I think this is missing a test to check for deprecation of fit_params, otherwise LGTM.
@adrinjalali |
3 participants
Reference Issues/PRs
towards #22893
What does this implement/fix? Explain your changes.
Adds metadata routing to
validation_curveand the corresponding tests.This PR is almost identical to #28975