adding array api test cases for paired_euclidean_distances#29389
Merged
OmarManzoor merged 5 commits intoscikit-learn:mainfrom Jul 23, 2024
Merged
Conversation
Contributor
Author
Member
|
I resolved the merge conflicts and started the CUDA CI (In the checks it is listed as "skipped" because I added the array APi label after the CUDA CI one and the jobs get skipped for that label. Let's see if the status gets updated once the jobs end) |
betatim
approved these changes
Jul 22, 2024
betatim
added
Quick Review
OmarManzoor
approved these changes
Jul 23, 2024
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @EmilyXinyi
MarcBresson
pushed a commit
to MarcBresson/scikit-learn
that referenced
this pull request
Sep 2, 2024
…arn#29389) Co-authored-by: Tim Head <betatim@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #26024
What does this implement/fix? Explain your changes.
paired_euclidean_distancesseems already compatible with the Array API. I am just adding the test