MAINT Deprecate scoring='max_error' and replace it by scoring='neg_max_error'#29462
Merged
adrinjalali merged 10 commits intoscikit-learn:mainfrom Jul 19, 2024
Merged
Conversation
lesteve
changed the title
Member
|
Thanks for your PR, I edited your description and PR title to help potential reviewers! |
lesteve
reviewed
Jul 17, 2024
lesteve
reviewed
Jul 17, 2024
lesteve
reviewed
Jul 17, 2024
lesteve
reviewed
Jul 18, 2024
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
adrinjalali
approved these changes
Jul 19, 2024
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
LGTM, and it seems consistent with the other work we've done.
This was referenced Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #29417
This deprecates
scoring='max_errorand replaces it withscoring='neg_max_error'.This is very similar to #14898 that did a similar thing for
scoring='brier_score_loss'=>scoring='neg_brier_score'What does this implement/fix? Explain your changes.
Renames the
max_errorscorer toneg_max_errorin order to make it consistent with other scorers that havegreater_is_better = False(and consistent with the documentation as well). Deprecatesmax_errorwith a deprecation warning message stating that it will be removed in v1.8.Any other comments?
Please remove the deprecation warning, deprecation test case and the two comment lines I added (which start with
XXX) once the old scorer is removed.