API move BaseEstimator._validate_data to utils.validation.validate_data by adrinjalali · Pull Request #29696 · scikit-learn/scikit-learn

adrinjalali · 2024-08-21T08:49:14Z

Alternative to and closes #29672

github-actions · 2024-08-21T08:50:40Z

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 5d7f6e7. Link to the linter CI: here}

glemaitre

I'm still uncertain about the naming of the function that does not reflect the mutation of estimator. validate_data_and_set_estimator will be an annoying name :)

I assume that we don't have an easy way to decoupled the data validation from the estimator mutation?

glemaitre

LGTM then.

adrinjalali · 2024-09-03T14:39:59Z

@adam2392 @Charlie-XIAO @OmarManzoor this should be a relatively easy one to review.

Charlie-XIAO

This LGTM, thanks @adrinjalali.

We may want to add an entry in doc/api_reference.py to reveal this public API in the docs (then I may review the rendering of the docstring).

…into validate_data2

adrinjalali · 2024-09-04T13:05:12Z

@Charlie-XIAO rendered docs are here https://output.circle-artifacts.com/output/job/68d06853-25a0-48f1-abc6-33835387baf0/artifacts/0/doc/modules/generated/sklearn.utils.validation.validate_data.html

Charlie-XIAO

Thanks @adrinjalali, here are some minor fixes to the docstring.

Charlie-XIAO · 2024-09-04T15:16:48Z

+        Only used if y is not None.
+        If False, call validate_X_y(). Else, it must be a tuple of kwargs
+        to be used for calling check_array() on X and y respectively.


Suggested change

Only used if y is not None.

If False, call validate_X_y(). Else, it must be a tuple of kwargs

to be used for calling check_array() on X and y respectively.

Only used if `y` is not `None`.

If `False`, call `validate_X_y()`. Else, it must be a tuple of kwargs

to be used for calling `check_array` on `X` and `y` respectively.

Is validate_X_y even a function within sklearn anymore? I can't find it anywhere.

Sorry, it's check_X_y

adam2392

Perhaps these will help link the different functions together?

adrinjalali · 2024-09-05T10:48:32Z

@adam2392 @Charlie-XIAO this should be good now

adam2392

LGTM!

thomasjpfan · 2024-09-05T13:19:40Z

+        `estimator=self` is automatically added to these dicts to generate
+        more informative error message in case of invalid input data.
+
+    cast_to_ndarray : bool, default=True


@adrinjalali I did not think too hard about the cast_to_ndarray parameter name when _valdiate_data was private. Do you see a better name for cast_to_ndarray?

I think what this array in practice is doing is skip_check_array really. So we could call it that? With Array API and sparse arrays and all that, I don't think "casting to ndarray" is quite accurate.

I like skip_check_array a lot more than cast_to_ndarray.

Charlie-XIAO

Thanks, a few more suggestions below:

Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com>

…into validate_data2

API move BaseEstimator._validate_data to utils.validation.validate_data

3a971a3

adrinjalali added this to the 1.6 milestone Aug 21, 2024

adrinjalali added the Developer API Third party developer API related label Aug 21, 2024

changelog

48eb221

adrinjalali mentioned this pull request Aug 29, 2024

API expose __validate_data__ as public developer API #29672

Closed

glemaitre self-requested a review September 3, 2024 09:57

glemaitre reviewed Sep 3, 2024

View reviewed changes

Comment thread sklearn/utils/validation.py Outdated

Comment thread sklearn/utils/validation.py Outdated

Comment thread sklearn/utils/validation.py

Comment thread sklearn/utils/validation.py

adrinjalali added 2 commits September 3, 2024 12:44

Better links to items

feafef8

Merge remote-tracking branch 'upstream/main' into validate_data2

914e1d3

glemaitre approved these changes Sep 3, 2024

View reviewed changes

adam2392 self-requested a review September 3, 2024 15:03

Charlie-XIAO reviewed Sep 3, 2024

View reviewed changes

glemaitre and others added 5 commits September 4, 2024 11:47

Merge branch 'main' into validate_data2

8ae2504

changelog

239dc0b

Merge branch 'validate_data2' of github.com:adrinjalali/scikit-learn …

b46ca76

…into validate_data2

Merge remote-tracking branch 'upstream/main' into validate_data2

b4ec2bf

changelog and api reference

fc9c661

Charlie-XIAO reviewed Sep 4, 2024

View reviewed changes

adam2392 reviewed Sep 4, 2024

View reviewed changes

Comment thread sklearn/utils/validation.py Outdated

Comment thread sklearn/utils/validation.py Outdated

adrinjalali added 3 commits September 5, 2024 10:23

doc improvements

58911b2

Merge remote-tracking branch 'upstream/main' into validate_data2

4dd60a9

new syntax

1c2b926

adam2392 approved these changes Sep 5, 2024

View reviewed changes

thomasjpfan reviewed Sep 5, 2024

View reviewed changes

Charlie-XIAO approved these changes Sep 5, 2024

View reviewed changes

Comment thread sklearn/utils/validation.py Outdated

Comment thread sklearn/utils/validation.py Outdated

Comment thread sklearn/utils/validation.py Outdated

Update sklearn/utils/validation.py

c58bea4

Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com>

adrinjalali and others added 4 commits September 5, 2024 16:15

Update sklearn/utils/validation.py

b7d31e7

Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com>

Update sklearn/utils/validation.py

02ff374

Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com>

rename cast_to_ndarray to skip_check_array

4b99a90

Merge branch 'validate_data2' of github.com:adrinjalali/scikit-learn …

5d7f6e7

…into validate_data2

adrinjalali merged commit 7d0bec5 into scikit-learn:main Sep 5, 2024

adrinjalali deleted the validate_data2 branch September 5, 2024 19:33

lbittarello mentioned this pull request Sep 6, 2024

Daily run failure: Unit tests Quantco/glum#830

Closed

stanmart mentioned this pull request Sep 9, 2024

Fix breakage caused by scikit-learn API changes Quantco/glum#832

Merged

1 task

SaravananSathyanandhaQC mentioned this pull request Sep 9, 2024

_check_n_features has moved Quantco/glum#835

Closed

icfaust mentioned this pull request Sep 13, 2024

[enhancement] conform to sklearn1.6 validate_data API change uxlfoundation/scikit-learn-intelex#2048

Merged

10 tasks

jameslamb mentioned this pull request Sep 24, 2024

[python-package] require scikit-learn>=0.24.2, make scikit-learn estimators compatible with scikit-learn>=1.6.0dev lightgbm-org/LightGBM#6651

Merged

JasperVanDenBosch mentioned this pull request Jun 30, 2025

Fix interface regression WeightedMDS for _validate_data rsagroup/rsatoolbox#444

Merged

hugobuddel mentioned this pull request Oct 5, 2025

_validate_data() and _check_n_features() have moved to utils crflynn/skranger#158

Open

Uh oh!

Uh oh!

Conversation

adrinjalali commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✔️ Linting Passed

Uh oh!

glemaitre left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

glemaitre left a comment

Choose a reason for hiding this comment

Uh oh!

adrinjalali commented Sep 3, 2024

Uh oh!

Charlie-XIAO left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adrinjalali commented Sep 4, 2024

Uh oh!

Charlie-XIAO left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Charlie-XIAO Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

adam2392 Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

adrinjalali Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

adam2392 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

adrinjalali commented Sep 5, 2024

Uh oh!

adam2392 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thomasjpfan Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

adrinjalali Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

thomasjpfan Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

adrinjalali Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

Charlie-XIAO left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

adrinjalali commented Aug 21, 2024 •

edited

Loading

github-actions Bot commented Aug 21, 2024 •

edited

Loading

glemaitre left a comment •

edited

Loading

Charlie-XIAO left a comment •

edited

Loading

adam2392 left a comment •

edited

Loading