ENH add support for array API to various metric#29709
Merged
ogrisel merged 156 commits intoscikit-learn:mainfrom Sep 27, 2024
Merged
ENH add support for array API to various metric#29709ogrisel merged 156 commits intoscikit-learn:mainfrom
ogrisel merged 156 commits intoscikit-learn:mainfrom
Conversation
in _weight_boosting.py.
`ensemble/_weight_boosting.py` file, moving it below the `Examples` section for improved organization. Included an AdaBoost example reference within the DecisionTree class in the `tree/-class.py` file.
…sion Trees user guide. - Modified the doc-string wording in the `AdaBoostClassifier` class referencing to the aforementioned example.
…related to temperature scaling.
OmarManzoor
approved these changes
Sep 10, 2024
root_mean_squared_log_error & mean_squared_log_error
Member
|
I'd like to see what @ogrisel thinks here. |
ogrisel
approved these changes
Sep 27, 2024
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM besides the following nitpicky suggestion. I will commit it and if CI goes through, it will auto-merge.
Member
Author
|
Thank you for your time! |
Member
|
I realized I merged with running the CUDA CI first... Let's be hopeful... |
Member
|
At least the tests pass with pytorch on MPS device, I tried locally. |
Member
|
All is fine with CUDA apparently: https://github.com/scikit-learn/scikit-learn/actions/runs/11076066477/job/30778541141 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #29678, #26024
What does this implement/fix? Explain your changes.
This PR updates the following functions in
sklearn.metrics:mean_absolute_errormean_absolute_percentage_errormean_squared_errorroot_mean_squared_errormean_squared_log_errorroot_mean_squared_log_errorSpecifically:
y_trueandy_predare within the correct domain for the functionmultioutput=uniform_average.Any other comments?
root_mean_squared_log_error&mean_squared_log_error#29686, which was closed due to re-branching.