Fixed array api support for MinMaxScaler with clip=True#29751
Merged
OmarManzoor merged 7 commits intoscikit-learn:mainfrom Sep 13, 2024
Merged
Fixed array api support for MinMaxScaler with clip=True#29751OmarManzoor merged 7 commits intoscikit-learn:mainfrom
OmarManzoor merged 7 commits intoscikit-learn:mainfrom
Conversation
ogrisel
reviewed
Sep 2, 2024
Contributor
Author
|
@ogrisel |
Member
|
The |
ogrisel
approved these changes
Sep 11, 2024
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
LGTM (if CI is still green after the last commit).
OmarManzoor
approved these changes
Sep 13, 2024
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @Shree7676
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29607
Sorry @StefanieSenger I did not see you were already working on it in #29615