ENH make check_is_fitted to always pass on stateless estimators#29880
Merged
OmarManzoor merged 5 commits intoscikit-learn:mainfrom Sep 20, 2024
Merged
ENH make check_is_fitted to always pass on stateless estimators#29880OmarManzoor merged 5 commits intoscikit-learn:mainfrom
OmarManzoor merged 5 commits intoscikit-learn:mainfrom
Conversation
OmarManzoor
approved these changes
Sep 18, 2024
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @adrinjalali
Contributor
|
@adrinjalali Some tests are failing. We might need to fix those. |
Member
|
Uhm I was too fast apparently, we are breaking some API here. |
Member
Author
|
So now |
Member
Author
|
Since this is different than when you did the review, I'll let you have another look @OmarManzoor @glemaitre |
thomasjpfan
approved these changes
Sep 19, 2024
OmarManzoor
approved these changes
Sep 20, 2024
kbharat1210
pushed a commit
to kbharat1210/scikit-learn
that referenced
this pull request
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
check_is_fittedpass on stateless estimators.cc @glemaitre @OmarManzoor