Skip to content

MAINT|API Clean up deprecations for 1.6: SAMME.R in AdaBoost and deprecate algorithm#29997

Merged
glemaitre merged 4 commits into
scikit-learn:mainfrom
jeremiedbb:cln-deprecations-1.6-samme.r
Oct 8, 2024
Merged

MAINT|API Clean up deprecations for 1.6: SAMME.R in AdaBoost and deprecate algorithm#29997
glemaitre merged 4 commits into
scikit-learn:mainfrom
jeremiedbb:cln-deprecations-1.6-samme.r

Conversation

@jeremiedbb

@jeremiedbb jeremiedbb commented Oct 3, 2024

Copy link
Copy Markdown
Member

Removed deprecated SAMME.R option of algorithm in AdaBoostClassifier and deprecated the algorithm param since there's now only 1 single valid option.

cc/ @glemaitre, cf #26784 (comment)

@github-actions

github-actions Bot commented Oct 3, 2024

Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5f05428. Link to the linter CI: here

@glemaitre
glemaitre self-requested a review October 8, 2024 18:23

@glemaitre glemaitre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread sklearn/ensemble/_weight_boosting.py Outdated
@glemaitre

Copy link
Copy Markdown
Member

Enabling auto-merge.

Thanks @jeremiedbb

@glemaitre
glemaitre merged commit 6de55b3 into scikit-learn:main Oct 8, 2024
BenJourdan pushed a commit to gregoryschwartzman/scikit-learn that referenced this pull request Oct 11, 2024
…ecate algorithm (scikit-learn#29997)

Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants