MAINT | API Clean up deprecations for 1.6: in make_scorer#30001
Merged
adrinjalali merged 3 commits intoOct 14, 2024
Merged
Conversation
glemaitre
reviewed
Oct 8, 2024
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
It looks good. Only a suggestion for the changelog and a question regarding the deprecation of None via the parameter validation.
|
|
||
| - |API| The default value of the `response_method` parameter of | ||
| :func:`metrics.make_scorer` will change from `None` to `"predict"` and `None` will be | ||
| removed in 1.8. |
Member
There was a problem hiding this comment.
Maybe we can also mention that in practice it will not change the behaviour of the function.
adrinjalali
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed deprecated parameters
needs_probaandneeds_thresholdsofmake_scorer.response_method=Nonewas possible during the deprecation cycle to detect when both are set but is now useless since it's equivalent to predict. This PR therefore deprecates None and announce the change of default to "predict" in 1.8.