FIX make sure that TFIDFVectorizer set idf_ dtype based on X.dtype#30022
Merged
adrinjalali merged 4 commits intoscikit-learn:mainfrom Oct 14, 2024
Merged
FIX make sure that TFIDFVectorizer set idf_ dtype based on X.dtype#30022adrinjalali merged 4 commits intoscikit-learn:mainfrom
adrinjalali merged 4 commits intoscikit-learn:mainfrom
Conversation
glemaitre
changed the title
OmarManzoor
approved these changes
Oct 11, 2024
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @glemaitre
OmarManzoor
added
the
Waiting for Second Reviewer
adrinjalali
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #30016
This PR makes sure that we fed an array of the same dtype as
Xin thenp.logto ensure thatidf_has also the same dtype thanX.This bug is only feasible in NumPy < 2. The casting inference in NumPy >= 2 will pick up the higher precision dtype from the left and right end side variables.