ENH remove _xfail_checks, pass directly to check runners, return structured output from check_estimator#30149
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29951, Fixes #30133
This moves
_xfail_checksout of the estimator tags._xfail_checkssince we haven't even released the new tags anyway.check_estimatornow doesn't raise aSkipTestWarningfor_xfailed_ checks, since they're not skipped. It also doesn't skip them at all, it runs all the checks.check_estimatornow returns a report ofxfailandskippedtests if it passes, and if it fails, the thrown exception has that same report included in it.