Fix PandasAdapter causes crash or misattributed features - #31079
Conversation
|
@glemaitre wondering if I can get a review? |
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks for the PR @nicolas-bolle. I think a higher level non regression test very similar the the reproducer that you posted in #31051 would be useful. Please also add a changelog entry.
f4fbd4c to
2b03d29
Compare
|
Thanks @nicolas-bolle. I just moved the test into the column transformer dedicated tests and made the changelog entry about a fix of the column transformer because we usually don't mention private API in the changelog and instead how it impacts the user. Please let me know if the new phrasing is fine, don't hesitate to edit it if it needs improvement. |
Yep thanks @jeremiedbb this looks great, thanks for the edits. Anything else needed before getting reviews? |
jeremiedbb
left a comment
There was a problem hiding this comment.
LGTM. Thanks @nicolas-bolle
…arn#31079) Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
…arn#31079) Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
…arn#31079) Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
…arn#31079) Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
…arn#31079) Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
…arn#31079) Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
Reference Issues/PRs
Fixes #31051. See also #28731.
What does this implement/fix? Explain your changes.
PandasAdaptercauses crash or misattributed features #31051 edge case where ColumnTransformer crashes because dataframes and series are handled differently by PandasAdapterAny other comments?