FIX: Corrected NuSVR impl type and set epsilon to None #315

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@TimSC

TimSC commented Aug 22, 2011

The implementation type for NuSVR was passing through epsilon_svr to the base class instead of nu_svr. Also, for NuSVR, epsilon is not used (although I realise that it is passed into libsvm's params but not used).

@agramfort

This comment has been minimized.

Show comment
Hide comment
@agramfort

agramfort Aug 22, 2011

Member

thanks ! did you check that the tests still pass?

Member

agramfort commented Aug 22, 2011

thanks ! did you check that the tests still pass?

@TimSC

This comment has been minimized.

Show comment
Hide comment
@TimSC

TimSC Aug 22, 2011

Yes, it passed the unit test. I am currently running tests on the performance and NuSVR seems to be more in line with my expectations.

Regards, Tim

TimSC commented Aug 22, 2011

Yes, it passed the unit test. I am currently running tests on the performance and NuSVR seems to be more in line with my expectations.

Regards, Tim

@bdholt1

This comment has been minimized.

Show comment
Hide comment
@bdholt1

bdholt1 Aug 22, 2011

Member

Welcome Tim! Glad you've joined scikits.learn!

@agramfort, the doctests also pass.

Member

bdholt1 commented Aug 22, 2011

Welcome Tim! Glad you've joined scikits.learn!

@agramfort, the doctests also pass.

@fabianp

This comment has been minimized.

Show comment
Hide comment
@fabianp

fabianp Aug 23, 2011

Member

Thanks Tim for the patch.

I've added some tests, fixed the same problem in the sparse module and pushed it all.

Member

fabianp commented Aug 23, 2011

Thanks Tim for the patch.

I've added some tests, fixed the same problem in the sparse module and pushed it all.

@fabianp fabianp closed this Aug 23, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment