FIX Revert tarfile_extractall clean-up#31685
Merged
Merged
Conversation
jeremiedbb
added
To backport
thomasjpfan
approved these changes
Jul 1, 2025
thomasjpfan
left a comment
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
LGTM. Only thing we need is a changelog entry for a bug fix release.
Member
lesteve
approved these changes
Jul 7, 2025
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 15, 2025
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31521
Closes #31523
tarfile_extractallwas removed in 1.7 because we thought that thefilterarg was added in Python 3.10 but it turns out that only Python 3.12 has it from the start (3.12.0). Previous versions introduced it as part of a micro version.