Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] DOC run optipng before uploading website #3355

Merged
merged 1 commit into from Jul 9, 2014

Conversation

larsmans
Copy link
Member

@larsmans larsmans commented Jul 9, 2014

Uses GNU find and xargs to run in parallel, because OptiPNG is very expensive on the sh*itload of PNGs we generate.

larsmans referenced this pull request Jul 9, 2014
Did "optipng -o 10" on all the files with OptiPNG 0.6.4.
This shaves a total of 529012 bytes off the pictures.

Conflicts:
	doc/testimonials/images/rangespan.png
	doc/testimonials/images/yhat.png
	doc/themes/scikit-learn/static/img/FNRS-logo.png

(Testimonials not on this branch, so I just deleted those images.)
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cfa61ab on larsmans:optipng into f2b3a09 on scikit-learn:master.

@GaelVaroquaux
Copy link
Member

👍 for merge. I'll trust you on the xargs syntax, cuz' I've never been too good at reading these.

@NelleV, it seems that you might want to use this when regenerating the website.

@GaelVaroquaux GaelVaroquaux changed the title DOC run optipng before uploading website [MRG+1] DOC run optipng before uploading website Jul 9, 2014
@larsmans
Copy link
Member Author

larsmans commented Jul 9, 2014

What I meant was really: I've no idea if this runs on a Mac too :p

@GaelVaroquaux
Copy link
Member

What I meant was really: I've no idea if this runs on a Mac too :p

@ogrisel?

@ogrisel
Copy link
Member

ogrisel commented Jul 9, 2014

Yes it works:

$ brew install OptiPNG

@ogrisel
Copy link
Member

ogrisel commented Jul 9, 2014

I confirm that make optipng works as expected on OSX.

@ogrisel
Copy link
Member

ogrisel commented Jul 9, 2014

👍 for merge, hence merging.

ogrisel added a commit that referenced this pull request Jul 9, 2014
[MRG+1] DOC run optipng before uploading website
@ogrisel ogrisel merged commit 4f98ce2 into scikit-learn:master Jul 9, 2014
@ogrisel
Copy link
Member

ogrisel commented Jul 9, 2014

Cherry-picked as 482c1df in the 0.15.X branch.

@ogrisel
Copy link
Member

ogrisel commented Jul 9, 2014

Apparently @larsmans also cherry-picked it as 4c6227f in 0.14.X.

@larsmans
Copy link
Member Author

larsmans commented Jul 9, 2014

No, that's a different commit. That's an offline optimization of the testimonial images.

@ogrisel
Copy link
Member

ogrisel commented Jul 9, 2014

I have also updated the salt-stack configuration of the rackspace box that builds the dev documentation:

https://github.com/scikit-learn/sklearn-docbuilder

@ogrisel
Copy link
Member

ogrisel commented Jul 9, 2014

No, that's a different commit. That's an offline optimization of the testimonial images.

Indeed. Can you please do the 0.14.X backport @larsmans? I need to get offline soonish.

@larsmans
Copy link
Member Author

larsmans commented Jul 9, 2014

03cb912

@ogrisel
Copy link
Member

ogrisel commented Jul 10, 2014

Thanks. @NelleV or @GaelVaroquaux has one of you rebuilt the 0.14.X branch with that last fix to rsync it to sourceforge?

@GaelVaroquaux
Copy link
Member

Thanks. @NelleV or @GaelVaroquaux has one of you rebuilt the 0.14.X
branch with that last fix to rsync it to sourceforge?

No me.

@ogrisel
Copy link
Member

ogrisel commented Jul 10, 2014

I am building a clean 0.14.X doc on my box right now.

@ogrisel
Copy link
Member

ogrisel commented Jul 10, 2014

I did an rsync with the results of make clean html optipng. The homepage seems to load fast enough now.

@larsmans larsmans deleted the optipng branch October 2, 2015 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants