Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[WIP] Skip common regressor test for OrthogonalMatchingPursuitCV on Travis #3381

Merged
merged 3 commits into from

4 participants

@kastnerkyle
Owner

omp_cv and related tests have issues on Travis. Should be fixed long term but for now this will skip the test_regressors_int when running common tests on Travis.

@coveralls

Coverage Status

Coverage increased (+0.0%) when pulling 2d7e32b on kastnerkyle:skip_omp_cv_regressors into dfeabda on scikit-learn:master.

@coveralls

Coverage Status

Coverage increased (+0.0%) when pulling 2d7e32b on kastnerkyle:skip_omp_cv_regressors into dfeabda on scikit-learn:master.

@ogrisel
Owner

+1 for MRG.

@GaelVaroquaux

:+1: Merging!!!

@GaelVaroquaux GaelVaroquaux merged commit 14d03f6 into scikit-learn:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 11 additions and 1 deletion.
  1. +11 −1 sklearn/tests/test_common.py
View
12 sklearn/tests/test_common.py
@@ -31,6 +31,7 @@
from sklearn.utils.testing import set_random_state
from sklearn.utils.testing import assert_greater
from sklearn.utils.testing import SkipTest
+from sklearn.utils.testing import check_skip_travis
import sklearn
from sklearn.base import (clone, ClassifierMixin, RegressorMixin,
@@ -792,13 +793,16 @@ def test_regressors_int():
rnd = np.random.RandomState(0)
y = rnd.randint(3, size=X.shape[0])
for name, Regressor in regressors:
- if name in dont_test or name in ('CCA'):
+ if name in dont_test or name == 'CCA':
continue
yield (check_regressors_int, name, Regressor, X,
multioutput_estimator_convert_y_2d(name, y))
def check_regressors_int(name, Regressor, X, y):
+ if name == 'OrthogonalMatchingPursuitCV':
+ # FIXME: This test is unstable on Travis, see issue #3190.
+ check_skip_travis()
rnd = np.random.RandomState(0)
# catch deprecation warnings
with warnings.catch_warnings(record=True):
@@ -836,6 +840,9 @@ def test_regressors_train():
def check_regressors_train(name, Regressor, X, y):
+ if name == 'OrthogonalMatchingPursuitCV':
+ # FIXME: This test is unstable on Travis, see issue #3190.
+ check_skip_travis()
rnd = np.random.RandomState(0)
# catch deprecation warnings
with warnings.catch_warnings(record=True):
@@ -879,6 +886,9 @@ def test_regressor_pickle():
def check_regressors_pickle(name, Regressor, X, y):
+ if name == 'OrthogonalMatchingPursuitCV':
+ # FIXME: This test is unstable on Travis, see issue #3190.
+ check_skip_travis()
rnd = np.random.RandomState(0)
# catch deprecation warnings
with warnings.catch_warnings(record=True):
Something went wrong with that request. Please try again.