[WIP] sample_weight support in DummyRegressor #3429

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
2 participants
@RolT

RolT commented Jul 18, 2014

Added weights support in for the DummyRegressor.
No tests done, not sure if it works yet.
For now, weighted and uniform strategies are separated, but I should merge it in the future.

@jnothman jnothman changed the title from [WIP] Weights to [WIP] sample_weight support in DummyRegressor Aug 7, 2014

@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller May 23, 2018

Member

It looks like you're also adding a new strategy in addition to the sample weights. Are you still working on this?

Member

amueller commented May 23, 2018

It looks like you're also adding a new strategy in addition to the sample weights. Are you still working on this?

@RolT

This comment has been minimized.

Show comment
Hide comment
@RolT

RolT May 23, 2018

Hi,
Dummy regressor seems to have both quantile strategy and sample weights implemented now so this PR is obsolete. I'm closing it.

RolT commented May 23, 2018

Hi,
Dummy regressor seems to have both quantile strategy and sample weights implemented now so this PR is obsolete. I'm closing it.

@RolT RolT closed this May 23, 2018

@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller May 23, 2018

Member

thanks for checking and sorry for the duplicate work (600 pull requests is a lot to try to keep in mind)

Member

amueller commented May 23, 2018

thanks for checking and sorry for the duplicate work (600 pull requests is a lot to try to keep in mind)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment