[MRG] Test list input #3430

Merged
merged 1 commit into from Jul 18, 2014

Conversation

Projects
None yet
3 participants
Owner

amueller commented Jul 18, 2014

Adds test for list input everywhere. On top of #3427.

@kastnerkyle kastnerkyle commented on an outdated diff Jul 18, 2014

sklearn/utils/estimator_checks.py
@@ -328,6 +329,28 @@ def check_estimators_nan_inf(name, Estimator):
raise AssertionError(error_string_transform, Estimator)
+def set_fast_parameters(estimator):
+ # speed up some estimators
+ params = estimator.get_params()
+ if "n_iter" in params:
+ estimator.set_params(n_iter=5)
+ if "max_iter" in params:
+ # NMF
+ estimator.set_params(max_iter=min(5, estimator.max_iter))
+ if "n_resampling" in params:
+ #randomized lasso
@kastnerkyle

kastnerkyle Jul 18, 2014

Owner

add a space here?

Owner

kastnerkyle commented Jul 18, 2014

This is very nice. Clearer comments, moved a lot of spaghetti into one place and also made things faster! 👍

Owner

amueller commented Jul 18, 2014

Fixed.
Reviews? @arjoly ;)

Owner

arjoly commented Jul 18, 2014

LGTM

@arjoly arjoly added a commit that referenced this pull request Jul 18, 2014

@arjoly arjoly Merge pull request #3430 from amueller/test_list_input
[MRG] Test list input
104d866

@arjoly arjoly merged commit 104d866 into scikit-learn:master Jul 18, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

amueller deleted the amueller:test_list_input branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment