[MRG+1] MAINT split sklearn/metrics/metrics.py #3442

Merged
merged 3 commits into from Jul 19, 2014

4 participants

@arjoly
scikit-learn member

As the title said.

This is a bit brutal, but file are of more manageable size.
It intends to fix #3425

@GaelVaroquaux
scikit-learn member

👍 for merge. The new layout is good!

@arjoly arjoly changed the title from MAINT split sklearn/metrics/metrics.py to [MRG+1] MAINT split sklearn/metrics/metrics.py Jul 19, 2014
@arjoly
scikit-learn member

a last +1? (ping @amueller, @ogrisel, @vene)

@jnothman jnothman and 1 other commented on an outdated diff Jul 19, 2014
sklearn/metrics/classification.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
"""Utilities to evaluate the predictive performance of models
@jnothman
scikit-learn member
jnothman added a line comment Jul 19, 2014

Can we get something a little bit more explanatory here?

@arjoly
scikit-learn member
arjoly added a line comment Jul 19, 2014

Thanks I forgot to change it in the refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jnothman jnothman commented on an outdated diff Jul 19, 2014
sklearn/metrics/ranking.py
@@ -0,0 +1,759 @@
+"""Utilities to evaluate the predictive performance of models
@jnothman
scikit-learn member
jnothman added a line comment Jul 19, 2014

More detail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jnothman
scikit-learn member

Do we need to retain a deprecated sklearn.metrics.metrics for backwards compatibility?

@arjoly
scikit-learn member

@jnothman I have taken your remark into account.

@arjoly
scikit-learn member

Do we need to retain a deprecated sklearn.metrics.metrics for backwards compatibility?

Documentation references sklearn.metrics and not sklearn.metrics.metrics.

@GaelVaroquaux
scikit-learn member

I need to touch the metrics module to fix some failures on numpy 1.9b2. Could this PR get an additional 👍, so that I avoid conflicts?

@arjoly
scikit-learn member

@amueller I have added the friendly warning.

+1 irl from @amueller

@GaelVaroquaux
scikit-learn member
@GaelVaroquaux GaelVaroquaux merged commit fa26f64 into scikit-learn:master Jul 19, 2014

1 check was pending

Details continuous-integration/travis-ci The Travis CI build is in progress
@arjoly arjoly deleted the arjoly:split-metrics-module branch Jul 19, 2014
@coveralls

Coverage Status

Coverage increased (+0.03%) when pulling c91a4af on arjoly:split-metrics-module into 0807e19 on scikit-learn:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment