Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[MRG+1] MAINT flatten metrics module and avoid nested bicluster module #3445

Merged
merged 3 commits into from Jul 19, 2014

Conversation

Projects
None yet
3 participants
Owner

arjoly commented Jul 19, 2014

No description provided.

Owner

arjoly commented Jul 19, 2014

negative line count + travis happy

I am switching to MRG

@arjoly arjoly changed the title from [WIP] MAINT flatten metrics module and avoid nested bicluster module to [MRG] MAINT flatten metrics module and avoid nested bicluster module Jul 19, 2014

@GaelVaroquaux GaelVaroquaux and 1 other commented on an outdated diff Jul 19, 2014

sklearn/metrics/cluster/__init__.py
__all__ = ["adjusted_mutual_info_score", "normalized_mutual_info_score",
"adjusted_rand_score", "completeness_score", "contingency_matrix",
"expected_mutual_information", "homogeneity_completeness_v_measure",
"homogeneity_score", "mutual_info_score", "v_measure_score",
- "entropy", "silhouette_samples", "silhouette_score",
- "consensus_score"]
+ "entropy", "silhouette_samples", "silhouette_score"]
@GaelVaroquaux

GaelVaroquaux Jul 19, 2014

Owner

Isn't that a breakage of public API? consensus_score has disappeared.

@arjoly

arjoly Jul 19, 2014

Owner

This means that people can do from sklearn.metrics.cluster import something?

I suppose that everybody does from sklearn import something

@GaelVaroquaux

GaelVaroquaux Jul 19, 2014

Owner

This means that people can do from sklearn.metrics.cluster import something?

I suppose that everybody does from sklearn import something

We cannot control for that, so I would rather not change it.

@GaelVaroquaux GaelVaroquaux changed the title from [MRG] MAINT flatten metrics module and avoid nested bicluster module to [MRG+1] MAINT flatten metrics module and avoid nested bicluster module Jul 19, 2014

Owner

GaelVaroquaux commented Jul 19, 2014

👍 for merge. Thanks

Owner

arjoly commented Jul 19, 2014

heisen omp error, thus travis is fine

Owner

kastnerkyle commented Jul 19, 2014

👍

@arjoly arjoly added a commit that referenced this pull request Jul 19, 2014

@arjoly arjoly Merge pull request #3445 from arjoly/flatten-metrics
[MRG+1] MAINT flatten metrics module and avoid nested bicluster module
8f68e54

@arjoly arjoly merged commit 8f68e54 into scikit-learn:master Jul 19, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details
Owner

arjoly commented Jul 19, 2014

Thanks !!!

@arjoly arjoly deleted the arjoly:flatten-metrics branch Jul 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment