Skip to content

[MRG+2] DOC make neural networks example appear #3460

Merged
merged 1 commit into from Jul 21, 2014

5 participants

@jnothman
scikit-learn member

Also make the absence of a README fail doc compilation

@gaelvaroquaux are you still sure you don't want to backport doc fixes?

@jnothman jnothman DOC make neural networks example appear
Also make the absence of a README fail doc compilation
98f2275
@ogrisel
scikit-learn member
ogrisel commented Jul 21, 2014

+1

@ogrisel ogrisel changed the title from DOC make neural networks example appear to [MRG] DOC make neural networks example appear Jul 21, 2014
@ogrisel
scikit-learn member
ogrisel commented Jul 21, 2014

@kastnerkyle as your are currently also reviewing doc issues, please have a look at this one as well.

+1 for backporting to 0.15.X if the backport is easy.

@kastnerkyle
scikit-learn member

This is just the RBM doc at present, right? Along with the general header where the GSoC examples should show up when they are merged?

@jnothman
scikit-learn member
@kastnerkyle
scikit-learn member

OK, I see it now and everything seems good. 👍 from me

@ogrisel ogrisel changed the title from [MRG] DOC make neural networks example appear to [MRG+2] DOC make neural networks example appear Jul 21, 2014
@ogrisel ogrisel added this to the 0.15.1 milestone Jul 21, 2014
@ogrisel ogrisel merged commit ff82157 into scikit-learn:master Jul 21, 2014

1 check passed

Details continuous-integration/travis-ci The Travis CI build passed
@ogrisel
scikit-learn member
ogrisel commented Jul 21, 2014

I merged in master. I added the 0.15.1 label to decide or not whether we backport to 0.15.X (I would be in favor of doing so if the backport is easy).

@ogrisel
scikit-learn member
ogrisel commented Jul 21, 2014

Thanks @jnothman for the fix and @kastnerkyle for checking on your box.

@amueller
scikit-learn member

The backport is super easy and I think we should do it. Can't believed I overlooked this one :-/

@amueller amueller referenced this pull request Jul 22, 2014
Closed

[WIP] Quantile dummy #3426

@GaelVaroquaux
scikit-learn member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.