Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issue 77 sparse cd #4

Merged
25 commits merged into from Sep 14, 2010

Conversation

Projects
None yet
1 participant
Owner

ogrisel commented Sep 9, 2010

Implementation of CD for elastic net on scipy.sparse data.

Missing: centered intercept, regularization path + example combining sparse and dense API at once

d_wii is a typo that comes from the dense version, it should spell d_w_ii: it means that the early stopping criterion is not working as expected at all. Furthermore Alexandre spotted that this is not scale invariant: the stopping test should be (d_w_max / w_max) < tol instead.
Both issues should be fixed there and also in the dense version in master before merging this branch.

Owner

ogrisel commented Sep 10, 2010

There is also a possibility of zero division error on features / columns that are always zeros: they need to be skipped.

Owner

ogrisel commented Sep 14, 2010

Ok I think all missing fixes are included now. This should be ready for merge to master.

@larsmans larsmans referenced this pull request in larsmans/scikit-learn Jul 15, 2011

@ogrisel ogrisel Merged pull request #4 from larsmans/master.
Update tutorial to match the current master API + typo. Thanks Lars.
f7afbcd

@amueller amueller referenced this pull request in amueller/scikit-learn Dec 21, 2011

@jakevdp jakevdp Merge pull request #4 from glouppe/dev-doc
Documentation
382bea2

@glouppe glouppe referenced this pull request in glouppe/scikit-learn Dec 11, 2012

@ndawe ndawe Merge pull request #4 from glouppe/treeweights
Some other fixes
e6baf3f

@ashimb9 ashimb9 added a commit to ashimb9/scikit-learn that referenced this pull request Jul 25, 2017

@ashimb9 ashimb9 Addressed review comments #4 d6aeaf3

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment