Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG+1] split data using _safe_split in _permutaion_test_scorer to fix error… #5697
referenced this pull request
Nov 30, 2015
First of all, sorry for the late reply.
I added the fix also to model_selection/_validation.py.
Moreover, I added a
Is there additional work that needs to be done before this can be merged? I'm still encountering the issue that this addresses (#5696), which I'm working around by calling .values on my series. Is it just the merge conflict that's hairy? If so, I'm happy to take a crack.
Hi guys, I rebased the fix it should be relatively easy to merge now (if it passes the checks).
@amueller I do not really get why this also fixes the issue using precomputed kernels / distance matrices with