New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1]Corrected OvO partial_fit to work in case labels are missing in some call #6250

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@kaichogami
Contributor

kaichogami commented Jan 29, 2016

Added tests of various scenarios, raised error in case mini-batch doesn't contain classes from all_classes.

Corrected OvO partial_fit to work in various test cases
Added tests of various scenarios, raised error in case mini-batch doesn't contain classes from all_classes.
@kaichogami

This comment has been minimized.

Show comment
Hide comment
@kaichogami

kaichogami Jan 31, 2016

Contributor

@MechCoder @GaelVaroquaux please review.

Contributor

kaichogami commented Jan 31, 2016

@MechCoder @GaelVaroquaux please review.

@kaichogami kaichogami changed the title from Corrected OvO partial_fit to work in various test cases to [MRG]Corrected OvO partial_fit to work in various test cases Feb 20, 2016

@kaichogami

This comment has been minimized.

Show comment
Hide comment
@kaichogami

kaichogami Feb 22, 2016

Contributor

@MechCoder please have a look at this when you are free. This was a follow up PR from #6200 for the OvO partial_fit method in case all classes are not present in some call.

Contributor

kaichogami commented Feb 22, 2016

@MechCoder please have a look at this when you are free. This was a follow up PR from #6200 for the OvO partial_fit method in case all classes are not present in some call.

@MechCoder

This comment has been minimized.

Show comment
Hide comment
@MechCoder

MechCoder Feb 22, 2016

Member

LGTM pending minor comments

Member

MechCoder commented Feb 22, 2016

LGTM pending minor comments

@MechCoder

This comment has been minimized.

Show comment
Hide comment
@MechCoder

MechCoder Feb 22, 2016

Member

Can you update the PR title to something more reasonable? For instance, "Corrected OvO partial_fit to work when each minibatch does not contain all labels"

Member

MechCoder commented Feb 22, 2016

Can you update the PR title to something more reasonable? For instance, "Corrected OvO partial_fit to work when each minibatch does not contain all labels"

@kaichogami kaichogami changed the title from [MRG]Corrected OvO partial_fit to work in various test cases to [MRG]Corrected OvO partial_fit to work in case labels are missing in some call Feb 23, 2016

@MechCoder

This comment has been minimized.

Show comment
Hide comment
@MechCoder

MechCoder Feb 23, 2016

Member

Use re.escape around the string you want to test.

Thanks to @vighneshbirodkar for debugging that!

Member

MechCoder commented Feb 23, 2016

Use re.escape around the string you want to test.

Thanks to @vighneshbirodkar for debugging that!

@kaichogami

This comment has been minimized.

Show comment
Hide comment
@kaichogami

kaichogami Feb 23, 2016

Contributor

Thanks @MechCoder and @vighneshbirodkar. This looks good now. :)

Contributor

kaichogami commented Feb 23, 2016

Thanks @MechCoder and @vighneshbirodkar. This looks good now. :)

@MechCoder MechCoder changed the title from [MRG]Corrected OvO partial_fit to work in case labels are missing in some call to [MRG+1]Corrected OvO partial_fit to work in case labels are missing in some call Feb 23, 2016

@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller Oct 8, 2016

Member

Could you please rebase? Sorry for the slow reply.

Member

amueller commented Oct 8, 2016

Could you please rebase? Sorry for the slow reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment