[MRG+1] Reduce duplicated code in _k_means.pyx #7053

Merged
merged 1 commit into from Jul 26, 2016

Conversation

Projects
None yet
3 participants
@yenchenlin
Contributor

yenchenlin commented Jul 20, 2016

This PR uses fused types function pointer to reduce unnecessary control flow code,
which can make it more readable.

@NelleV

This comment has been minimized.

Show comment
Hide comment
@NelleV

NelleV Jul 25, 2016

Member

That looks good.
+1

Member

NelleV commented Jul 25, 2016

That looks good.
+1

@NelleV NelleV changed the title from [MRG] Reduce duplicated code in _k_means.pyx to [MRG+1] Reduce duplicated code in _k_means.pyx Jul 25, 2016

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Jul 26, 2016

Member

LGTM, thanks

Member

jnothman commented Jul 26, 2016

LGTM, thanks

@jnothman jnothman merged commit 2ace75b into scikit-learn:master Jul 26, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 94.487%
Details

olologin added a commit to olologin/scikit-learn that referenced this pull request Aug 24, 2016

TomDLT added a commit to TomDLT/scikit-learn that referenced this pull request Oct 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment