Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Reduce duplicated code in _k_means.pyx #7053

Merged
merged 1 commit into from Jul 26, 2016

Conversation

@yenchenlin
Copy link
Contributor

yenchenlin commented Jul 20, 2016

This PR uses fused types function pointer to reduce unnecessary control flow code,
which can make it more readable.

@yenchenlin yenchenlin force-pushed the yenchenlin:refactor-k_means-cython branch from d075396 to 8731843 Jul 20, 2016
@NelleV
Copy link
Member

NelleV commented Jul 25, 2016

That looks good.
+1

@NelleV NelleV changed the title [MRG] Reduce duplicated code in _k_means.pyx [MRG+1] Reduce duplicated code in _k_means.pyx Jul 25, 2016
@jnothman
Copy link
Member

jnothman commented Jul 26, 2016

LGTM, thanks

@jnothman jnothman merged commit 2ace75b into scikit-learn:master Jul 26, 2016
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 94.487%
Details
olologin added a commit to olologin/scikit-learn that referenced this pull request Aug 24, 2016
TomDLT added a commit to TomDLT/scikit-learn that referenced this pull request Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.